Add apollo and update some packages #157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnml1135
requested review from
TaperChipmunk32 and
ddaspit
and removed request for
TaperChipmunk32
ddaspit
requested changes
Feb 21, 2025
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion
a discussion (no related file):
We should hold off on this until we do more research into APOLLO.
Collaborator
|
Closing this PR but leaving the branch. Once sillsdev/silnlp#668 is complete, we can revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be part of a broader discussion as to whether to add Apollo. We may also choose to add it but maintain the adamw as default right now.
This change is